[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e11be38c-7901-a38f-7de6-edaa6a3be06c@codeaurora.org>
Date: Mon, 27 Jun 2016 10:30:51 -0700
From: "Zhao, Weiming" <weimingz@...eaurora.org>
To: musl@...ts.openwall.com
Subject: Re: Fix warnings when build with clang
I don't think it's a compiler bug. Neither a functionality issue in MUSL.
Its a warning about code readability / sanity and we can fix it in 2
seconds, which can make build process looks more clean.
Weiming
On 6/27/2016 10:21 AM, Rich Felker wrote:
> On Mon, Jun 27, 2016 at 10:01:52AM -0700, weimingz@...eaurora.org wrote:
>> On 2016-06-25 02:37, Szabolcs Nagy wrote:
>>> * Zhao, Weiming <weimingz@...eaurora.org> [2016-06-24 17:18:23 -0700]:
>>>> Clang gives warnings about the missing parentheses for bitwise ops.
>>>>
>>>> It's not functional but just code readability.
>>>>
>>>> musl-m3/include/endian.h:32:25: warning: '&' within '|'
>>>> [-Wbitwise-op-parentheses]
>>>> return __x>>24 | __x>>8&0xff00 | __x<<8&0xff0000 | __x<<24;
>>>> ~ ~~~~~~^~~~~~~
>>> if clang warns about system headers that's a clang bug.
>> The endian.h is a musl file.
> Right, which is why it's a system header.
>
> Rich
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
