musl - Undetected failures in getdomainname

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <576A491D.7030509@nicta.com.au>
Date: Wed, 22 Jun 2016 18:15:25 +1000
From: Matthew Fernandez <matthew.fernandez@...ta.com.au>
To: <musl@...ts.openwall.com>
Subject: Undetected failures in getdomainname

Hi all,

In the tip at time of writing (6cec7bc57f599f43f4041cec2093e3c9231dbaab) there are a couple of
syscalls that are implemented by calling uname, notably gethostname and getdomainname. In
gethostname, the return value of uname is checked and the code returns early if uname fails.
However, in getdomainname the return value of uname is ignored. I think it should be following the
same pattern as gethostname. Is this correct?

Also, gethostname rolls its own strcpy, while getdomainname just calls strcpy. However, maybe there
is a good reason for this.

If replying, please CC me directly as I'm not on the list.

Thanks,
Matthew

________________________________

The information in this e-mail may be confidential and subject to legal professional privilege and/or copyright. National ICT Australia Limited accepts no liability for any damage caused by this email or its attachments.

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.