[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160420171841.GV21636@brightrain.aerifal.cx>
Date: Wed, 20 Apr 2016 13:18:41 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH 04/12] update elf.h with new aarch64 relocs
On Wed, Apr 20, 2016 at 01:15:37PM +0200, Szabolcs Nagy wrote:
> add ilp32 related relocs and fix the names of a few macros following
> https://sourceware.org/ml/libc-alpha/2014-11/msg00455.html
> ---
> include/elf.h | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/include/elf.h b/include/elf.h
> index 1bfe016..0dcc1f2 100644
> --- a/include/elf.h
> +++ b/include/elf.h
> @@ -2105,8 +2105,17 @@ typedef Elf32_Addr Elf32_Conflict;
> #define SHT_ARM_PREEMPTMAP (SHT_LOPROC + 2)
> #define SHT_ARM_ATTRIBUTES (SHT_LOPROC + 3)
>
> -
> #define R_AARCH64_NONE 0
> +#define R_AARCH64_P32_ABS32 1
> +#define R_AARCH64_P32_COPY 180
> +#define R_AARCH64_P32_GLOB_DAT 181
> +#define R_AARCH64_P32_JUMP_SLOT 182
> +#define R_AARCH64_P32_RELATIVE 183
> +#define R_AARCH64_P32_TLS_DTPMOD 184
> +#define R_AARCH64_P32_TLS_DTPREL 185
> +#define R_AARCH64_P32_TLS_TPREL 186
> +#define R_AARCH64_P32_TLSDESC 187
> +#define R_AARCH64_P32_IRELATIVE 188
> #define R_AARCH64_ABS64 257
> #define R_AARCH64_ABS32 258
> #define R_AARCH64_ABS16 259
> @@ -2224,9 +2233,9 @@ typedef Elf32_Addr Elf32_Conflict;
> #define R_AARCH64_GLOB_DAT 1025
> #define R_AARCH64_JUMP_SLOT 1026
> #define R_AARCH64_RELATIVE 1027
> -#define R_AARCH64_TLS_DTPMOD64 1028
> -#define R_AARCH64_TLS_DTPREL64 1029
> -#define R_AARCH64_TLS_TPREL64 1030
> +#define R_AARCH64_TLS_DTPMOD 1028
> +#define R_AARCH64_TLS_DTPREL 1029
> +#define R_AARCH64_TLS_TPREL 1030
> #define R_AARCH64_TLSDESC 1031
Did you test this? From what I can see, it breaks the build, though I
don't have a cross compiler handy to actually check. See
arch/aarch64/reloc.h. If there's a possibility any other software is
using the old names we should probably add rather than change (like
the OR1K/OPENRISC issue).
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
