musl - [PATCH 0/3] env functions overhaul

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1457895230-13602-1-git-send-email-amonakov@ispras.ru>
Date: Sun, 13 Mar 2016 21:53:47 +0300
From: Alexander Monakov <amonakov@...ras.ru>
To: musl@...ts.openwall.com
Subject: [PATCH 0/3] env functions overhaul

Hello,

recently, fixing benign UB in unsetenv unearthed bigger issues in putenv, and
prompted an overhaul. I still have to improve env testing on libc-test side,
but I think I'm done with code tuning on the musl side, and pretty happy with
the result. Patches 2 and 3 are followups to stuff discussed on IRC; I feel
they are not essential. Patch 1 is the overhaul itself. I hope that new code
is easy to follow. It should also improve code size nicely; on x86-64 I got
(.text size change after patch 1/3 only; .bss grows by one pointer):

   text   text   filename
     17     17   obj/src/env/clearenv.o
    140     97   obj/src/env/getenv.o
    491    334   obj/src/env/putenv.o
    215    284   obj/src/env/setenv.o
    283    140   obj/src/env/unsetenv.o

Thanks.
Alexander

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.