[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160311045850.GV9349@brightrain.aerifal.cx>
Date: Thu, 10 Mar 2016 23:58:50 -0500
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] Add `intl` to EMPTY_LIB_NAMES.
On Tue, Mar 08, 2016 at 02:50:51PM +0900, OGINO Masanori wrote:
> It makes programs that depend on libintl work with musl.
>
> Signed-off-by: OGINO Masanori <masanori.ogino@...il.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index ec54880..394b32f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -60,7 +60,7 @@ GENERIC_INCLUDES = $(wildcard $(srcdir)/arch/generic/bits/*.h)
> INCLUDES = $(wildcard $(srcdir)/include/*.h $(srcdir)/include/*/*.h)
> ALL_INCLUDES = $(sort $(INCLUDES:$(srcdir)/%=%) $(GENH:obj/%=%) $(ARCH_INCLUDES:$(srcdir)/arch/$(ARCH)/%=include/%) $(GENERIC_INCLUDES:$(srcdir)/arch/generic/%=include/%))
>
> -EMPTY_LIB_NAMES = m rt pthread crypt util xnet resolv dl
> +EMPTY_LIB_NAMES = m rt pthread crypt util xnet resolv dl intl
> EMPTY_LIBS = $(EMPTY_LIB_NAMES:%=lib/lib%.a)
> CRT_LIBS = $(addprefix lib/,$(notdir $(CRT_OBJS)))
> STATIC_LIBS = lib/libc.a
Sorry for not responding to this sooner. I think we need more
information to know if this is a good idea. The other libs in
EMPTY_LIBS are standard names specified by POSIX, whereas libintl is a
GNU thing, and I think some distros are using GNU libintl alongside
musl (mainly for legacy reasons). Adding this might break things for
them. From what I remember, the core problem here is that the autoconf
tests for gettext wrongly detect that musl does not have a suitable
gettext (because they probe for glibc-internal symbols) and these
packages are trying to use an external GNU libintl instead. Perhaps
someone who's followed the issue closely could link to the old threads
on it, or bugtracker items?
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
