[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160308112613.GX29662@port70.net>
Date: Tue, 8 Mar 2016 12:26:13 +0100
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Cc: "Rich Felker (dalias@...c.org)" <dalias@...c.org>
Subject: Re: RE: [PATCH] MIPS64 atomic_arch.h Clang complains about
input type
* Jaydeep Patil <Jaydeep.Patil@...tec.com> [2016-03-08 10:09:43 +0000]:
>
> ./arch/mips64/atomic_arch.h:37:29: error: unsupported inline asm: input with type 'long *' matching output with type 'int'
>
clang probably should not complain about this
(it's possible to have the output in the low 32bit of a 64bit input reg
and then you do want mismatching input/output types for the same reg)
> #define a_sc_p a_sc_p
> -static inline int a_sc_p(volatile long *p, void *v)
> +static inline void *a_sc_p(volatile long *p, void *v)
> {
> - int r;
> + void *r;
> __asm__ __volatile__ (
> "scd %0, %1"
> : "=r"(r), "=m"(*p) : "0"(v) : "memory");
the return type should be int (1 on success, 0 on failure)
e.g. you can use 'long r' instead of 'int r'
if clang still complains then maybe
union {void *v; long r;} u = {v};
__asm__ __volatile__ (
"scd %0, %1" : "+r"(u.v), "=m"(*p) :: "memory");
return u.r;
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
