[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAA-4+jfYeRLqTaMaqt6a3R91hM0wtkpLHQzTaEewUX4RJubDAA@mail.gmail.com>
Date: Tue, 8 Mar 2016 14:45:38 +0900
From: Masanori Ogino <masanori.ogino@...il.com>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] Define LONG_DOUBLE_IS_* internal macros.
2016-03-08 14:05 GMT+09:00 Rich Felker <dalias@...c.org>:
> On Tue, Mar 08, 2016 at 11:38:15AM +0900, OGINO Masanori wrote:
>> These macros indicate which format is used for long double with the
>> toolchain.
>>
>> Although the meaning of "LDBL_DIG_MANT == 64 && LDBL_MAX_EXP == 16384"
>> is very clear to floating-point arithmetic guys, it is nice to have
>> descriptive names to such conditions.
>
> I understand where you're coming from but I think this is opposite to
> the style preferences in musl, which are to avoid dependence on
> internal things and directly use portable conditions based on public
> interfaces where possible. The existing tests are all completely valid
> even outside musl, without depending on any musl-internal stuff. If
> the intent is not clear, perhaps some simple comments would suffice?
OK, now I understood that. I think original code is clear enough; it
seems just a matter of taste.
Thank you for your advice.
--
Masanori Ogino
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
