[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20151002101823.GR8645@brightrain.aerifal.cx>
Date: Fri, 2 Oct 2015 06:18:23 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH 1/3] Pull a couple common AWK functions for CFI
scripts into separate file
On Fri, Oct 02, 2015 at 12:02:01PM +0200, Alex Dowad wrote:
> There is a lot which could be common between i386 and x86_64, but none of it
> will be useful for any other arch. These should be useful for all archs,
> however.
> ---
> Makefile | 2 +-
> tools/add-cfi.i386.awk | 27 ---------------------------
> tools/common.awk | 26 ++++++++++++++++++++++++++
> 3 files changed, 27 insertions(+), 28 deletions(-)
> create mode 100644 tools/common.awk
>
> diff --git a/Makefile b/Makefile
> index 5a6a43b..761482d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -122,7 +122,7 @@ $(foreach s,$(wildcard src/*/$(ARCH)*/*.s),$(eval $(call mkasmdep,$(s))))
> # Choose invocation of assembler to be used
> # $(1) is input file, $(2) is output file, $(3) is assembler flags
> ifeq ($(ADD_CFI),yes)
> - AS_CMD = LC_ALL=C awk -f tools/add-cfi.$(ARCH).awk $< | $(CC) -x assembler -c -o $@ -
> + AS_CMD = LC_ALL=C awk -f tools/common.awk -f tools/add-cfi.$(ARCH).awk $< | $(CC) -x assembler -c -o $@ -
Is the name common.awk appropriate? (common to what?) Maybe cfi-common
or something that indicates it's for the cfi scripts.
Great to see further work on this!
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
