Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1443780123-6493-2-git-send-email-alexinbeijing@gmail.com>
Date: Fri,  2 Oct 2015 12:02:02 +0200
From: Alex Dowad <alexinbeijing@...il.com>
To: musl@...ts.openwall.com
Subject: [PATCH 2/3] When generating CFI for i386 asm, don't mistake an FDIV instruction for DIV

...that would cause the script to erroneously conclude that the values of EAX
and EDX have been overwritten.

Probably won't make a difference, but it's just as well to get it right...
---
 tools/add-cfi.i386.awk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/add-cfi.i386.awk b/tools/add-cfi.i386.awk
index b8bdd7f..2da1899 100644
--- a/tools/add-cfi.i386.awk
+++ b/tools/add-cfi.i386.awk
@@ -190,7 +190,7 @@ function trashed(register) {
 }
 /i?mul [^,]*$/                    { trashed("eax"); trashed("edx") }
 /i?mul %e(ax|bx|cx|dx|si|di|bp),/ { trashed(get_reg1()) }
-/i?div/                           { trashed("eax"); trashed("edx") }
+/^i?div/                          { trashed("eax"); trashed("edx") }
 /(dec|inc|not|neg|pop) %e(ax|bx|cx|dx|si|di|bp)/  { trashed(get_reg()) }
 /cpuid/ { trashed("eax"); trashed("ebx"); trashed("ecx"); trashed("edx") }
 
-- 
2.0.0.GIT

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.