Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150820013400.GA14179@dora.lan>
Date: Wed, 19 Aug 2015 20:34:00 -0500
From: Bobby Bingham <koorogi@...rogi.info>
To: musl@...ts.openwall.com
Subject: Re: SuperH conflict of arch/sh/__set_thread_area vs
 thread/__set_thread_area

On Thu, Aug 20, 2015 at 02:44:11AM +0200, Christian Lamparter wrote:
> Hello,
> 
> I'm trying to add a port for a SH4-like ARCH to OpenWRT, which uses the latest
> musl-1.1.10 as the default libc. I'm having the following problem when building
> the toolchain:
> 
> During the final linker-step, the symbol "__set_thread_area"  declared twice.
> This is because the SH architecture provides a separate __set_thread_area [0],
> (other archs use the standard syscall wrapper from [1]).

There is an empty file src/thread/sh/__set_thread_area.s which should be
overriding src/thread/__set_thread_area.c.  Therefore, only the definition
from arch/sh/src/__set_thread_area.c should be getting linked in.

Can you tell why src/thread/__set_thread_area.c is still getting used?

> 
> Obviously, I want this issue fixed. However I'm new to SuperH and musl, that's
> why I need advise :-D. For now, I defined the src/thread/__set_thread_area as
> a weak symbol. Now, that's just a crude hack, what would be better solution?
> (I can make and post the patch if necessary - But sadly, I can't test it on the
> hardware yet)?
> 
> Regards,
> Christian  
> 
> [0] <http://git.musl-libc.org/cgit/musl/tree/arch/sh/src/__set_thread_area.c>
> [1] <http://git.musl-libc.org/cgit/musl/tree/src/thread/__set_thread_area.c>

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.