[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150813200649.GC27440@port70.net>
Date: Thu, 13 Aug 2015 22:06:50 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: Jan V??el?k <jan.vcelak@....cz>
Cc: musl@...ts.openwall.com
Subject: Re: strptime() lacks support for %z
* Jan V??el?k <jan.vcelak@....cz> [2015-08-13 20:56:47 +0200]:
> (Please CC me in replies, I'm not subscribed to the list.)
>
> The strptime() function lacks support for %z (and %Z) format specifier.
>
> I'm mostly interested in '%z' because we are using it the Knot DNS
> project and we have been notified by one of our users running Alpine
> Linux that the previously written time stamps cannot be parsed.
>
> I want to contribute to musl by implementing the missing specifier.
> But honestly I don't know how to start. The strptime() function needs
> some refactoring otherwise the change would be ugly (or copy-pasta).
>
> Are you interested in this feature? Please, can you point me to your
> coding style guidelines? How can I check I haven't broken anything else?
> Do you have unit tests or something?
>
we have some tests, but not for strptime unfortunately.
the problem with parsing timezones is that it's not posix
so the desired semantics is not clear (struct tm has no
tz field in posix and it is not obvious how that should
be treated in other apis that use struct tm.. glibc does
something but it should be verified to give consistent
behaviour if we add this to musl and there might be parsing
corner cases when %z is not surrounded by spaces..).
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
