Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150506231901.GO17573@brightrain.aerifal.cx>
Date: Wed, 6 May 2015 19:19:01 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] fix futimes(fd, 0)

On Thu, May 07, 2015 at 12:55:19AM +0200, Szabolcs Nagy wrote:
> * Felix Janda <felix.janda@...teo.de> [2015-05-07 00:10:28 +0200]:
> > Pass on 0 to futimens without trying to dereference it.
> 
> is there a reason to accept 0 argument?
> 
> there are other cases when the libc has to do fixups
> to the passed arguments and it dereferences the pointer
> which should be valid

Yes, see the man page:

http://man7.org/linux/man-pages/man3/futimes.3.html

It defers to utimes for the actual behavior, which is a standard
(albeit deprecated) function, and has specified behavior for the null
pointer case.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.