[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150425171417.GU17573@brightrain.aerifal.cx>
Date: Sat, 25 Apr 2015 13:14:17 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] fmtmsg: verify that label is in the correct
format.
On Sat, Apr 25, 2015 at 09:15:35AM -0700, Isaac Dunham wrote:
> According to POSIX, "the format is two fields separated by a colon.
> The first field is up to 10 bytes, the second is up to 14 bytes."
> The original implementation assumed that the application provided
> a valid label.
Is there a particular problem you're trying to solve? It's not clear
to me from the text (which seems under-specified) whether there's an
obligation to diagnose errors here, or whether failure to meet the
contract for the format of the inputs yields unspecified or undefined
behavior. I'm not necessarily opposed to the change but I'd like to
understand this better so that it would be well-motivated.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
