Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150418222853.GK6817@brightrain.aerifal.cx>
Date: Sat, 18 Apr 2015 18:28:53 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: ppc fix

On Sat, Apr 18, 2015 at 11:10:17PM +0100, Justin Cormack wrote:
> Starting to look at powerppc64, can you apply the following patch to
> fix the detection macro, it is __PPC64__ not __PPC64. Attached as well
> in case MTA mangles it.
> 
> Justin
> 
> 
> diff --git a/arch/powerpc/bits/syscall.h b/arch/powerpc/bits/syscall.h
> index acd825a..a3c2c90 100644
> --- a/arch/powerpc/bits/syscall.h
> +++ b/arch/powerpc/bits/syscall.h
> @@ -194,7 +194,7 @@
>  #define __NR_vfork                  189
>  #define __NR_ugetrlimit             190
>  #define __NR_readahead              191
> -#if !defined(__PPC64) || defined(__ABI32)
> +#if !defined(__PPC64__) || defined(__ABI32)

This header is for the 32-bit powerpc arch; I'm not sure why these
#ifdefs ever got committed to begin with. As part of the arch/bits
deduplication effort (coming up) it may make sense to use a unified
source file for powerpc and powerpc64, but it would probably be
processed by the build system rather than having installed #ifdefs.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.