[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150105154631.GI4574@brightrain.aerifal.cx>
Date: Mon, 5 Jan 2015 10:46:31 -0500
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: Possible bug in openlog()
On Mon, Jan 05, 2015 at 03:39:14PM +0200, Dima Krasner wrote:
> Hi,
>
> I think I found a bug in openlog() - it's racy. If syslogd is
> started after openlog() is called, there's a small chance that the
> socket will remain open, while connect() failed. Then, syslog() does
> not call openlog() again, because it only checks whether the socket
> file descriptor is valid.
>
> Therefore, all syslog() messages are dropped silently and nothing
> gets logged. I attached a fix.
>
> Can you merge it or provide feedback, please?
Did you observe this in practice? All accesses to log_fd seem to be
made with the syslog lock held. If you think there's missing
synchronization somewhere please elaborate.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
