musl - Wrong wcsnrtombs return value and positive NaNs printing

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANfjmEBJbObTf38+SphzT349ygZEzY7Ov1E3mpi4yRuj219vhw@mail.gmail.com>
Date: Thu, 18 Dec 2014 20:20:00 +0300
From: Oleg Ranevskyy <llvm.mail.list@...il.com>
To: musl@...ts.openwall.com
Subject: Wrong wcsnrtombs return value and positive NaNs printing

Hello musl community,

I encountered two problems with musl when running the LLVM libc++ tests
linked against it.

1. The wcsnrtombs function returns the number of converted wide chars
instead of the dst length in bytes. "cnt++;" at the of the function should
actually be "cnt += l;".

2. If a NaN value is printed by vfprintf and the MARK_POS flag is set to
add '+' to positive values, musl doesn't add '+'. I found the following
statement on the musl web page: "Quiet nans are treated equally (there is
only one logical nan value, it is printed as "nan", the library does not
care about the sign and payload of nan)". However, Linux libc adds '+',
boost also has special support for this. Absence of the sign breaks one of
the LLVM libc++ tests. Is this a subject for change?

Would you be able to kindly review these findings and share your opinion
please?

Thanks in advance.
Warm regards,
Oleg

Content of type "text/html" skipped

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.