[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20141214004320.GA17102@brightrain.aerifal.cx>
Date: Sat, 13 Dec 2014 19:43:20 -0500
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Merging ns_parse from Alpine
I'm working on merging Timo's patch for ns_parse:
http://git.alpinelinux.org/cgit/aports/tree/main/musl/1001-add-basic-dns-record-parsing-functions.patch?id=81d50064c335467fdfd80368bac6707d70db1af7
The first issue that came up in the process is that arpa/nameser.h,
which was previously not used by musl itself and really should never
have been accepted in its current form, is full of junk like
statement-expressions. Including it in a file that will be compiled
with musl adds build dependency on these nonstandard features. I
cleaned that up with no problem (just un-inlining the macros since
we're adding function versions anyway), but there are a few more
issues.
The main issue is that the parser functions have pointer arithmetic
overflows (UB) checking against the end-of-message pointer. I've tried
to fix that and I'm attaching a patch for review, along with my
version of the fixed file. I'd appreciate comments on whether I missed
anything.
Other changes were mostly cosmetic or at least mechanical.
Rich
View attachment "ns_parse_changes_v1.diff" of type "text/plain" (3504 bytes)
View attachment "ns_parse.c" of type "text/plain" (3966 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
