[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20141102044812.GO22465@brightrain.aerifal.cx>
Date: Sun, 2 Nov 2014 00:48:12 -0400
From: Rich Felker <dalias@...c.org>
To: musl@...ts.openwall.com
Subject: Re: the prototype decl of memcpy/memcmp/calloc/free
shouldnot in sched.h
On Sat, Nov 01, 2014 at 01:02:36PM -0400, Rich Felker wrote:
> On Sat, Nov 01, 2014 at 05:22:30PM +0100, Szabolcs Nagy wrote:
> > * ????????? <jianzhong.huang@...oft.com.cn> [2014-10-31 11:42:35 +0800]:
> > >
> > > In firefox, there is a system_wrapper header include sched.h, but in hunspell codes, calloc and free was redefined, so there is a conflicts here.
> > > for example, in "extensions/spellcheck/hunspell/src/hunspell_alloc_hooks.h"
> > > #define calloc(count, size) HunspellAllocator::CountingCalloc(count, size)
> > >
> >
> > a simple fix for that in musl is
> >
> > void *(calloc)(size_t, size_t);
> >
> > or
> >
> > #define CPU_ALLOC(n) __cpu_alloc(n)
> > static __inline cpu_set_t *__cpu_alloc(size_t _n)
> > {
> > extern void *(calloc)(size_t,size_t);
> > return (calloc)(1,CPU_ALLOC_SIZE(_n));
> > }
> >
> > which almost gets the namespace right: only a non-function like
> > calloc macro defined before sched.h would be an issue
>
> Yes, I like moving the declarations to non-file-scope better.
I think we should do this, but while looking at how, I noticed a
couple other issues:
1. Useless declaration of memcpy, which is unused.
2. Use of memset without a declaration.
Just making a note here so I don't overlook these when fixing it.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
