Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20141016083739.GA2525@zx-spectrum.accesssoftek.com>
Date: Thu, 16 Oct 2014 11:37:39 +0300
From: Sergey Dmitrouk <sdmitrouk@...esssoftek.com>
To: "musl@...ts.openwall.com" <musl@...ts.openwall.com>
Subject: Re: Constants to decode __ctype_b_loc() table

On Wed, Oct 15, 2014 at 07:07:12PM -0700, Rich Felker wrote:
> In the link you cited:
> 
>     "This interface is not in the source standard; it is only in the
>     binary standard."

Even if it's a binary interface, it shouldn't be underspecified.  Right
now __ctype_b_loc.c contains an array of numbers which correspond to
what glibc has.  Consider the following situation: glibc changes masks
at some point, musl doesn't, someone uses masks from new glibc's
headers after reading a thread like this one and obtains broken locales.

Having this documented in form of a comment instead of public interface
would be good as well, in this case clients could consult place where
it's documented and be sure that their constants are correct.  Say, add
a comment to __ctype_b_loc.c to clarify meaning of the table and
document masks at the same time.

Regards,
Sergey

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.