[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20140715164546.GE17402@brightrain.aerifal.cx>
Date: Tue, 15 Jul 2014 12:45:46 -0400
From: Rich Felker <dalias@...c.org>
To: Brent Cook <busterb@...il.com>, musl@...ts.openwall.com,
beck@...nbsd.org, Brent Cook <brent@...ndary.com>
Subject: Re: [PATCH] implement issetugid(2) (v3)
On Tue, Jul 15, 2014 at 06:16:57PM +0200, Szabolcs Nagy wrote:
> * Brent Cook <busterb@...il.com> [2014-07-15 15:40:46 +0000]:
> > --- a/include/unistd.h
> > +++ b/include/unistd.h
> > @@ -192,6 +192,10 @@ int euidaccess(const char *, int);
> > int eaccess(const char *, int);
> > #endif
> >
> > +#ifdef _BSD_SOURCE
> > +int issetugid(void);
> > +#endif
> > +
>
> in musl _BSD_SOURCE is a subset of _GNU_SOURCE
> so it should be used with || defined(_GNU_SOURCE)
>
> (_GNU_SOURCE actually means 'everything' instead of
> 'gnu', and _BSD_SOURCE means 'default', but they are
> very close to the usual gnu/bsd feature set applications
> expect
Yes. I think we should go ahead and change the names to
_DEFAULT_SOURCE and _ALL_SOURCE and put the remapping from _BSD_SOURCE
and _GNU_SOURCE into features.h. This would eliminate confusion about
whether something should be BSD or BSD|GNU.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
