[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1405209291-1455-1-git-send-email-bcook@openbsd.org>
Date: Sat, 12 Jul 2014 17:54:51 -0600
From: Brent Cook <bcook@...nbsd.org>
To: musl@...ts.openwall.com
Cc: beck@...nbsd.org, Brent Cook <brent@...ndary.com>
Subject: [PATCH] implement issetugid(2)
From: Brent Cook <brent@...ndary.com>
>From OpenBSD 2.0 and later, NetBSD, FreeBSD, OS X and Solaris
http://www.openbsd.org/cgi-bin/man.cgi?query=issetugid&sektion=2
While getauxval(AT_SECURE) might have been able to provide comparable
functionality on the libc versions that support it, several Linux libc
versions implement it in a way such that the results cannot be trusted,
since there is no way to tell if it has failed. Worse, the result of '0'
returned on failures effectively causes the security mechanism to fail
'open'.
There is also no simultaneously reliable and portable way for a
library to identify if the C library has a usable version of getauxval,
since the symbol is unversioned. Compile-time checks for usability are
also unfeasible, since static libraries built with a 'good' version can
be linked to a 'bad' version of getauxval.
The fix is to implement the BSD issetugid(2) interface so that a
portable library can use its presence to determine if the underlying C
library has a reliable way of determining the value of AT_SECURE, and by
extension if the library is running with elevated privileges. If the
call fails, it assumes secure mode rather than falling back to an
insecure result.
---
include/unistd.h | 3 +++
src/unistd/issetugid.c | 10 ++++++++++
2 files changed, 13 insertions(+)
create mode 100644 src/unistd/issetugid.c
diff --git a/include/unistd.h b/include/unistd.h
index bb19cd8..3990c1e 100644
--- a/include/unistd.h
+++ b/include/unistd.h
@@ -109,6 +109,9 @@ uid_t geteuid(void);
gid_t getgid(void);
gid_t getegid(void);
int getgroups(int, gid_t []);
+#if defined(_BSD_SOURCE)
+int issetugid(void);
+#endif
int setuid(uid_t);
int setreuid(uid_t, uid_t);
int seteuid(uid_t);
diff --git a/src/unistd/issetugid.c b/src/unistd/issetugid.c
new file mode 100644
index 0000000..f538626
--- /dev/null
+++ b/src/unistd/issetugid.c
@@ -0,0 +1,10 @@
+#include <sys/auxv.h>
+#include "libc.h"
+
+int issetugid(void)
+{
+ size_t *auxv = libc.auxv;
+ for (; *auxv; auxv+=2)
+ if (*auxv==AT_SECURE) return auxv[1] != 0;
+ return 1;
+}
--
1.9.1
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
