[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <539BECF4.7080107@midipix.org>
Date: Sat, 14 Jun 2014 02:34:28 -0400
From: "writeonce@...ipix.org" <writeonce@...ipix.org>
To: musl@...ts.openwall.com
Subject: Re: [RFC] [v2] Implement errc/warnc family of functions
On 06/13/2014 10:33 PM, Isaac Dunham wrote:
> On Fri, Jun 13, 2014 at 12:33:23PM -0400, Rich Felker wrote:
>> On Thu, Jun 12, 2014 at 11:06:23PM -0700, Isaac Dunham wrote:
>>> I was trying to build netbsd sed, and it needed errc.
>>> So I wrote an errc implementation.
>> There was another patch for this about a month ago; look back and see
>> the thread. I'm not opposed to adding it as long as we can minimize
>> the code duplication between these ugly functions (but they're pretty
>> small anyway).
> That was actually how this came to my attention at first; however, the
> implementation you refer to was nonsense, since vwarnx does *not* have the
> prototype
> void vwarnx(int, const char *, va_list);
Yes, that was a typo that persisted throughout the thread. It should
have read 'vwarnc'.
zg
>
> I'm not sure whether to go for adding it or not, since apparently netbsd
> doesn't have it in libc.
> I've also removed it from my local version of sed, andd am half-tempted to
> go ahead and use POSIX "formatted error messages", a.k.a. fmtmsg() ;)
>
> But if it's going in,
> vwarn(fmt, ap);
> is supposed to be equivalent to
> vwarnc(errno, fmt, ap);
>
> So I could easily shrink that part.
> I'm sending a second version, because it's trivial to fix.
>
> HTH,
> Isaac Dunham
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
