[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20131123212759.GZ24286@brightrain.aerifal.cx>
Date: Sat, 23 Nov 2013 16:27:59 -0500
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] Fix dn_comp prototype and add stub
On Tue, Nov 05, 2013 at 03:26:22PM +0100, Szabolcs Nagy wrote:
> * Michael Forney <mforney@...rney.org> [2013-11-04 21:42:34 -0800]:
> > -int dn_comp(unsigned char *, unsigned char *, int, unsigned char **, unsigned char *, unsigned char **);
> > +int dn_comp(unsigned char *, unsigned char *, int, unsigned char **, unsigned char **);
>
> bsd and glibc declaration is
>
> int dn_comp(const char *, u_char *, int, u_char **, u_char **);
>
> (the linux man is wrong about the first argument)
Indeed. Michael, could you submit a revised version of this patch?
BTW, I think keeping the __-prefixed alias is okay and may actually be
useful for ABI-compat purposes; it looks like glibc's resolv.h exposes
the __-prefixed symbol names (via #define), so glibc-linked binaries
will be looking for the symbol with __.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
