[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20131109163603.GG24286@brightrain.aerifal.cx>
Date: Sat, 9 Nov 2013 11:36:03 -0500
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: Re: request: increase TTY_NAME_MAX in limits.h
On Sat, Nov 09, 2013 at 11:07:32AM +0000, Laurent Bercot wrote:
> Hello,
>
> TTY_NAME_MAX is currently 20. This is not enough for me. Could it
> be increased a bit ?
The only thing that needs to be checked is if there are any places
where increasing the value could cause buffer overflows (in an
existing binary already compiled with the value of 20). A casual
glance does not show any such issues.
> Explanation: my /dev is actually a symlink to /mnt/tmpfs/dev, and
> ttyname_r() writes fully resolved paths, so "/mnt/tmpfs/dev/pts/0"
> is *just* too large to fit into the 20 bytes static buffer provided
> by ttyname().
> Impact: it breaks dropbear, which instantly dies when ttyname() fails -
> this is a deal breaker for me. Less importantly, it also breaks the %y%
> prompt mechanism in zsh, which prints the default "tty" instead of the
> correct name.
Understood.
> I'd like to be able to use prebuilt musl toolchains, like Gregor's ones,
> or Rob's ones when they come out, so editing limits.h myself won't cut it.
> 24 bytes would be enough for me to have 10k ptys (which will never happen).
> So... can I haz 4 more bytes plz ?
If we change it I think we might as well go with the glibc value of 32
rather than just increasing it by 4.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
