Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20131021232015.GI1685@port70.net>
Date: Tue, 22 Oct 2013 01:20:16 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: Re: Re: inet_pton

* Szabolcs Nagy <nsz@...t70.net> [2013-10-22 00:25:17 +0200]:

> * Paul Schutte <sjpschutte@...il.com> [2013-10-21 21:59:16 +0200]:
> > I have tested the suggested fix and this is the result:
> 
> i've added your test cases to libc-test and some more
> which revealed further issues
> 

these two changes fix the v6 bugs, but leading zeros of the v4 part
are still swallowed incorrectly (even if v4 parsing gets fixed)

-       if (s[0]==':' && s[1]==':') s++;
+       if (s[0]==':' && *++s!=':') return 0;

-                       if (s[j]!='.') return 0;
+                       if (s[j]!='.' || (i<6 && brk<0)) return 0;

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.