musl - Re: time code progress

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130717142737.GV15323@port70.net>
Date: Wed, 17 Jul 2013 16:27:38 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: Re: time code progress

* Rich Felker <dalias@...ifal.cx> [2013-07-17 09:31:10 -0400]:
> I'm glad to hear this is the worst bug found so far. :-)
> 

here is another one:
posix seems to require EOVERFLOW when the result cannot be represented
(i cleaned up my mktime/gmtime test copied from libc-testsuit)

diff --git a/src/time/mktime.c b/src/time/mktime.c
index e38b461..ef1fb42 100644
--- a/src/time/mktime.c
+++ b/src/time/mktime.c
@@ -25,6 +25,6 @@ time_t mktime(struct tm *tm)
        return t;
 
 error:
-       errno = EINVAL;
+       errno = EOVERFLOW;
        return -1;
 }

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.