Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20130616143830.GN29800@brightrain.aerifal.cx>
Date: Sun, 16 Jun 2013 10:38:30 -0400
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] bugfix: invalid use of cb in io_thread after
 suspension of the thread

On Sun, Jun 16, 2013 at 11:55:22AM +0200, Jens Gustedt wrote:
> It seems that the buffer variable to which cb is pointing can be recycled
> since long when the thread returns from the previous call to wake. At

It's not just the call to wake. Accessing cb is invalid immediately
after the a_store to cb->__err.

> The fix is easy: the event structure has been copied onto the stack of
> the thread, anyhow, so just use that copy.

Agreed. I'm applying the fix.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.