Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <5140A8C4.1050207@eservices.virginia.edu>
Date: Wed, 13 Mar 2013 12:26:44 -0400
From: Zvi Gilboa <zg7s@...rvices.virginia.edu>
To: <musl@...ts.openwall.com>
Subject: inttypes.h: possible logical error?

Greetings,

In inttypes.h, the first "actual" lines read:

...
#include <features.h>
#include <stdint.h>

#define __NEED_wchar_t
#include <bits/alltypes.h>
...

As it seems, the idea is to have <bits/alltypes.h> processed with  
__NEED_wchar_t  already defined.  However, <bits/alltypes.h> is also 
included by <stdint.h>.

In a way this is rather harmless, specifically since <bits/alltypes.h> 
can be processed more than once, yet wouldn't it be more logical and/or 
consistent to #define __NEED_wchar_t  prior to including <stdint.h>?  
Given no conflicting considerations, the above code snippet would then read:

...
#define __NEED_wchar_t

#include <features.h>
#include <stdint.h>
#include <bits/alltypes.h> /* possibly redundant?  see stdint.h */
...

Thanks in advance for any and all feedback!

Best regards,
Zvi Gilboa

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.