[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130226064929.GC20323@brightrain.aerifal.cx>
Date: Tue, 26 Feb 2013 01:49:29 -0500
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: Re: Fix for fields in utmp
On Wed, Feb 20, 2013 at 07:56:35PM -0500, Rich Felker wrote:
> On Wed, Feb 20, 2013 at 07:49:37PM +0100, Szabolcs Nagy wrote:
> > * Chris Spiegel <cspiegel@...il.com> [2013-02-20 10:23:09 -0800]:
> > > The utmp.h header defines a few macros to access __ut_exit in the utmpx
> > > struct; however, the underscores were removed in utmpx, so the macros
> > > now point to non-existent struct members. Attached is a simple patch
> > > which removes them.
> >
> > note that the current code is not compatible with glibc
> >
> > http://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/gnu/bits/utmpx.h
> > vs
> > http://git.musl-libc.org/cgit/musl/tree/include/utmpx.h
> >
> > it seems the __ prefix depends on _GNU_SOURCE
>
> The versions with the __ prefix are never intended to be accessed by
> name; they're just there to get the padding right. If some programs do
> use them, however, we might need to provide them... BTW this is all
> stub code; musl does not use utmp.
Committed. If anyone demonstrates a need for compatibility with the
__-prefixed names, we can discuss supporting them too, but this is all
really just ugly cruft...
> > and the 64bit abi is different on musl
> > (see ut_session and ut_tv)
>
> That should be fixed. Since it's all stubs, I don't think ABI is a big
> issue here.
Can you elaborate on what needs to be changed here?
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
