[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20130211102415.GZ6181@port70.net>
Date: Mon, 11 Feb 2013 11:24:16 +0100
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] move the definition of __pthread_tsd_main in the
only compilation unit that references it
* Jens Gustedt <Jens.Gustedt@...ia.fr> [2013-02-11 10:19:44 +0100]:
> This also avoids a const cast that doesn't seem to be very useful.
>
> 0 3 src/thread/pthread_key_create.c
> 4 4 src/thread/pthread_self.c
>
> diff --git a/src/thread/pthread_key_create.c b/src/thread/pthread_key_create.c
> index e51cb02..084cbaa 100644
> --- a/src/thread/pthread_key_create.c
> +++ b/src/thread/pthread_key_create.c
> @@ -1,8 +1,5 @@
> #include "pthread_impl.h"
>
> -const size_t __pthread_tsd_size = sizeof(void *) * PTHREAD_KEYS_MAX;
> -void *__pthread_tsd_main[PTHREAD_KEYS_MAX] = { 0 };
> -
> static void (*keys[PTHREAD_KEYS_MAX])(void *);
__pthread_tsd_size was used in pthread_attr_setstack, so
we guarantee that the thread has at least that much stack
but recently the policy was changed around tls see
git log --patch src/thread/pthread_attr_setstack.c
so yes __pthread_tsd_size is not used anymore
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
