[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20121214133342.GQ23126@port70.net>
Date: Fri, 14 Dec 2012 14:33:42 +0100
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: Re: spandsp build, lrint/sqrt/pow issue
* ojab <ojab@...b.ru> [2012-12-14 16:59:57 +0400]:
> Thanks for the quick fix, lrint issue is fixed. Right now build
> fails only on sqrt() and pow():
> awgn.c: In function 'awgn_init_dbov':
> awgn.c:109:14: warning: cast to pointer from integer of different size
> awgn.c:109:14: warning: cast to pointer from integer of different size
> awgn.c:109:14: warning: cast to pointer from integer of different size
> awgn.c:109:5: error: void value not ignored as it ought to be
>
> and line 109:
> s->rms = pow(10.0, level/20.0)*32768.0;
>
>
> Next issue is
> awgn.c: In function 'awgn':
> awgn.c:165:15: warning: cast to pointer from integer of different size
> awgn.c:165:15: warning: cast to pointer from integer of different size
> awgn.c:165:9: error: void value not ignored as it ought to be
> awgn.c:165:9: warning: type defaults to 'int' in type name
>
> and line 165:
> fac = sqrt(-2.0*log(r)/r);
>
both of these expressions work here (i386, gcc-4.4)
i think your compiler does not like the tgmath __RETCAST magic
and i have no idea what went wrong
> So I suppose the fix is needed (don't know if it should be on musl
> side though).
> spandsp use tgmath.h only if available, so if I'll remove tgmath.h
> or undefine HAVE_TGMATH_H ? spandsp builds fine.
my point is that they shouldn't use it at all
(at least not in that particular translation unit, it's not wrong,
but pointless, it just makes compilation slow and fragile)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
