Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20121118204602.GV20323@brightrain.aerifal.cx>
Date: Sun, 18 Nov 2012 15:46:02 -0500
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: Re: sysinfo padding question

On Sun, Nov 18, 2012 at 08:25:48PM +0000, Justin Cormack wrote:
> Why is the padding for sysinfo for the kernel different from the libc
> one for Musl?
> 
> /usr/include/linux/kernel.h has 	char
> _f[20-2*sizeof(long)-sizeof(int)];	/* Padding: libc5 uses this.. */
> /usr/include/sys/sysinfo.h has       char __reserved[256];
> 
> glibc just includes the kernel header from sys/sysinfo.h so both these
> structs are the same size there, so not sure I see any rationale.

I don't think there was any particular rationale; I just did it to
make sure there's plenty of space for future expansion. Changing it to
match should be fine unless anybody objects. Note however that the
glibc definition gives no room to expand on 64-bit.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.