[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <50834470.2030502@embtoolkit.org>
Date: Sun, 21 Oct 2012 02:40:16 +0200
From: Abdoulaye Walsimou GAYE <awg@...toolkit.org>
To: musl@...ts.openwall.com
Subject: Re: [PATCH 3/4] Import BSD functions defined in <netinet/ether.h>
from NetBSD
On 10/21/2012 01:37 AM, idunham@...abit.com wrote:
>> +#ifndef _NETINET_ETHER_H
>> +#define _NETINET_ETHER_H
>> +
>> +#include <sys/cdefs.h>
>> +__BEGIN_DECLS
> musl does not do nested includes unless *necessary*, nor do we define
> macros unless it simplifies the code significantly.
> This detail speeds up compilation significantly.
>
> #ifdef __cplusplus
> extern "C" {
> #endif
>
> is NOT something that obscures the code, and it certainly isn't worth
> adding another nested include.
>
>> +char *ether_ntoa(const struct ether_addr *);
>> +struct ether_addr *ether_aton(const char *);
>> +int ether_ntohost(char *, const struct ether_addr *);
>> +int ether_hostton(const char *, struct ether_addr *);
>> +int ether_line(const char *, struct ether_addr *, char *);
>> +__END_DECLS
> Make that
> #ifdef __cplusplus
> }
> #endif
>
>> +#endif /* !_NETINET_ETHER_H */
> No comments in headers, and certainly not this trivial.
>
>
I see, I will send another patch!
Cheers,
AWG
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
