Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120817121059.GT27715@brightrain.aerifal.cx>
Date: Fri, 17 Aug 2012 08:10:59 -0400
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: Re: Todo for release?

On Fri, Aug 17, 2012 at 11:49:01AM +0200, Szabolcs Nagy wrote:
> * Rich Felker <dalias@...ifal.cx> [2012-08-15 10:36:40 -0400]:
> > On Wed, Aug 15, 2012 at 03:32:57PM +0200, Szabolcs Nagy wrote:
> > > it seems warn(0) and err(1,0) segfault
> > > (they should handle fmt==0 before passing
> > > it to vfprintf)
> > > and they do not print the ': ' nor the
> > > __progname
> > 
> > Thanks for the report. This should be easy to fix. By the way, is it
> > worth making these functions take a lock on the file for the whole
> > operation (to make it atomic)? I'm leaning towards no, since they seem
> > to only be used in legacy junk that's all single-threaded anyway.
> 
> i dont mind if the file is not locked although it would not
> itroduce too much overhead..
> 
> the ": " is not fixed, i think that should be added

Oh, my intent was for perror to do the printing of it. I forgot perror
special cases not only NULL but also ""...

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.