musl - Re: ldso : bug dependencies symbol lookup

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120807231215.GD27715@brightrain.aerifal.cx>
Date: Tue, 7 Aug 2012 19:12:15 -0400
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: Re: ldso : bug dependencies symbol lookup

On Tue, Aug 07, 2012 at 04:55:50PM +0200, musl wrote:
> Hi,
> 
> I think there is a bug in symbol lookup since this commit : 05eff01e89ee345e70acdbebc9c3778766b76ee2.
> 
>         if (p->deps) for (i=0; p->deps[i]; i++) {
> -               sym = lookup(s, h, p->deps[i]->syms,
> -                       p->deps[i]->hashtab, p->deps[i]->strings);
> +               sym = lookup(s, h, p);
>                 if (sym && sym->st_value && (1<<(sym->st_info&0xf) & OK_TYPES))
>                         return p->deps[i]->base + sym->st_value;
>         }
> 
> this should be :
> 
>         if (p->deps) for (i=0; p->deps[i]; i++) {
> -               sym = lookup(s, h, p->deps[i]->syms,
> -                       p->deps[i]->hashtab, p->deps[i]->strings);
> +               sym = lookup(s, h, p->deps[i]);
>                 if (sym && sym->st_value && (1<<(sym->st_info&0xf) & OK_TYPES))
>                         return p->deps[i]->base + sym->st_value;
>         }

Thanks! Fixed in git.

Rich

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.