[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120806192241.2ed1108f@newbook>
Date: Mon, 6 Aug 2012 19:22:41 -0700
From: Isaac Dunham <idunham@...abit.com>
To: musl@...ts.openwall.com
Subject: Re: [PATCH 1/10] ioperm & iopl
On Sun, 22 Jul 2012 18:13:32 -0700
Isaac Dunham <idunham@...abit.com> wrote:
> This adds ioperm & iopl along with io.h, though a full io.h has
> several more syscalls.
I've been looking into some fixes for the current state, and have a few
questions...
1. These are only appropriate on PC arches (plus a few old PC-like
systems, like Alpha). However, they are C, so make doesn't build them.
Should I add a per-arch *.c rule to the Makefile? (this seems better to
me than adding an #ifdef and building an empty file on other arches)
2. To add per-arch headers in include/sys/, should I
mkdir arch/${ARCH}/sys/
?
Will this require changing the makefile?
3. I'm thinking to copy in the macros, and would like a few tips on
style:
-I assume I should delete needless comments such as
/* Basic I/O macros */
..
#endif /* _SYS_IO_H */
-static inline or static ?
Thanks,
Isaac Dunham
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
