Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120613145603.GD163@brightrain.aerifal.cx>
Date: Wed, 13 Jun 2012 10:56:03 -0400
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: Re: FreeSec crypt()

On Wed, Jun 13, 2012 at 05:18:07PM +0400, Solar Designer wrote:
> > Note that even if the behavior were defined, this code seems to have
> > different behavior for high bytes depending on the signedness of char.
> 
> Do you mean high bits (not bytes)?

"High bytes" is a poorly defined term I used to mean bytes with their
high bit set, or bytes outside the ASCII range, etc.

> Why would signedness of char matter
> if the behavior of the signed char overflowing left shift were defined?

Well if char is signed, (char)0x80 << 1 is -256. If char is unsigned,
(char)0x80 << 1 is 256.

Rich

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.