musl - musl security advisory #001: stack buffer overflow in vfprintf with long output

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20120417152440.GR7281@brightrain.aerifal.cx>
Date: Tue, 17 Apr 2012 11:24:40 -0400
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: musl security advisory #001: stack buffer overflow in vfprintf with
 long output

This issue affects all recent versions of musl up through 0.8.7, and
is presumably exploitable if you can get a program to print arbitrary
strings to stderr using fprintf. The following commit fixes the issue
in current git, and the patch should apply cleanly to any previous
version of musl released within the past year.


commit b5a8b28915aad17b6f49ccacd6d3fef3890844d1
Author: Rich Felker <dalias@...ifal.cx>
Date:   Tue Apr 17 10:58:02 2012 -0400

    fix buffer overflow in vfprintf on long writes to unbuffered files
    
    vfprintf temporarily swaps in a local buffer (for the duration of the
    operation) when the target stream is unbuffered; this both simplifies
    the implementation of functions like dprintf (they don't need their
    own buffers) and eliminates the pathologically bad performance of
    writing the formatted output with one or more write syscalls per
    formatting field.
    
    in cases like dprintf where we are dealing with a virgin FILE
    structure, everything worked correctly. however for long-lived files
    (like stderr), it's possible that the buffer bounds were already set
    for the internal zero-size buffer. on the next write, __stdio_write
    would pick up and use the new buffer provided by vfprintf, but the
    bound (wend) field was still pointing at the internal zero-size
    buffer's end. this in turn allowed unbounded writes to the temporary
    buffer.

diff --git a/src/stdio/vfprintf.c b/src/stdio/vfprintf.c
index 928c8c1..91c6b93 100644
--- a/src/stdio/vfprintf.c
+++ b/src/stdio/vfprintf.c
@@ -652,8 +652,9 @@ int vfprintf(FILE *f, const char *fmt, va_list ap)
 	FLOCK(f);
 	if (!f->buf_size) {
 		saved_buf = f->buf;
-		f->buf = internal_buf;
+		f->wpos = f->wbase = f->buf = internal_buf;
 		f->buf_size = sizeof internal_buf;
+		f->wend = internal_buf + sizeof internal_buf;
 	}
 	ret = printf_core(f, fmt, &ap2, nl_arg, nl_type);
 	if (saved_buf) {

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.