Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120406084808.1c71d502@newbook>
Date: Fri, 6 Apr 2012 08:48:08 -0700
From: Isaac Dunham <idunham@...abit.com>
To: musl@...ts.openwall.com
Subject: Re: [PATCH] _BSD_SOURCE for unistd.h, take 2

On Fri, 6 Apr 2012 10:48:29 -0400
Rich Felker <dalias@...ifal.cx> wrote:
> Looking at this again, it looks to me like almost all of the functions
> under _GNU_SOURCE are also present on BSD. That is to say, just
> replacing #ifdef _GNU_SOURCE with
> 
> #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE)
> 
> would give a closer approximation to what _BSD_SOURCE is supposed to
> do. I'm not saying this is the best solution, but before I go
> committing patches to support _BSD_SOURCE, 
Yep, looks like I missed some.
get_current_dir_name, setresuid and setresgid (as well as forkall...)
are the only ones that aren't defined with _BSD_SOURCE.

Still, I tend to prefer having some respect for even unofficial
namespaces.

Attached is a patch (3rd revision) that has all the _BSD_SOURCE
functions properly classified.

Isaac Dunham
View attachment "unistd.diff" of type "text/x-patch" (974 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.