[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110607090609.GB5512@port70.net>
Date: Tue, 7 Jun 2011 11:06:09 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: Re: Cleanup patches
* Igmar Palsenberg <musl@...senberg.com> [2011-06-07 10:44:44 +0200]:
> The cast should be OK. In cases where it is correct (and the cast isn't necessary), it is simply a NOOP.
>
a superfluous type cast is not OK even if it's a NOOP
it's ugly, dangerous and surprising
in this case the cast hides an important warning:
wchar_t of musl and the compiler is different
the solution is to define wchar_t properly
it seems pcc and gcc defines __WCHAR_TYPE__
if clang has it defined as well then i guess musl can use it
and fall back to int when it's not defined
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
