Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200604185752.GA28210@pi3.com.pl>
Date: Thu, 4 Jun 2020 20:57:52 +0200
From: Adam Zabrocki <pi3@....com.pl>
To: lkrg-users@...ts.openwall.com
Subject: Re: Re: Support for 5.7 linux kernel?

Hey,

On Thu, Jun 04, 2020 at 08:37:47PM +0200, Mikhail Morfikov wrote:
> On 04/06/2020 19:42, Adam Zabrocki wrote:
> > Hi,
> > 
> > I've just pushed a basic verification if necessary CONFIG_* options are 
> > enabled. If I miss something in the latest commit, I will be incrementaly 
> > adding them.
> > 
> > Please try to recompile the module and check if it works.
> 
> Still some issues:
> 
> # modprobe -v p_lkrg
> insmod /lib/modules/5.7.0-amd64/updates/dkms/p_lkrg.ko
> 
> # lsmod
> Module                  Size  Used by
> p_lkrg                245760  0
> 
> So it loads, but in the syslog:
> 
> Jun 04 20:32:32 morfikownia kernel: p_lkrg: loading out-of-tree module taints kernel.
> Jun 04 20:32:32 morfikownia kernel: [p_lkrg] Loading LKRG...
> Jun 04 20:32:32 morfikownia kernel: BUG: using smp_processor_id() in preemptible [00000000] code: modprobe/5461
> Jun 04 20:32:32 morfikownia kernel: caller is p_parse_module_params+0x161/0x28c [p_lkrg]
> Jun 04 20:32:32 morfikownia kernel: CPU: 0 PID: 5461 Comm: modprobe Tainted: G           O    T 5.7.0-amd64 #5
> Jun 04 20:32:32 morfikownia kernel: Hardware name: LENOVO 2349BM5/2349BM5, BIOS G1ETC2WW (2.82 ) 08/07/2019
> Jun 04 20:32:32 morfikownia kernel: Call Trace:
> Jun 04 20:32:32 morfikownia kernel:  dump_stack+0x50/0x68
> Jun 04 20:32:32 morfikownia kernel:  debug_smp_processor_id.cold+0x4e/0x53
> Jun 04 20:32:32 morfikownia kernel:  p_parse_module_params+0x161/0x28c [p_lkrg]
> Jun 04 20:32:32 morfikownia kernel:  p_lkrg_register+0x50/0x1000 [p_lkrg]
> Jun 04 20:32:32 morfikownia kernel:  ? 0xffffffffc0499000
> Jun 04 20:32:32 morfikownia kernel:  do_one_initcall+0x5b/0x240
> Jun 04 20:32:32 morfikownia kernel:  do_init_module+0x5f/0x230
> Jun 04 20:32:32 morfikownia kernel:  load_module+0x2709/0x29e0
> Jun 04 20:32:32 morfikownia kernel:  ? __do_sys_finit_module+0xc2/0x120
> Jun 04 20:32:32 morfikownia kernel:  __do_sys_finit_module+0xc2/0x120
> Jun 04 20:32:32 morfikownia kernel:  do_syscall_64+0xa4/0x5f1
> Jun 04 20:32:32 morfikownia kernel:  ? do_syscall_64+0x30/0x5f1
> Jun 04 20:32:32 morfikownia kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xa9
> Jun 04 20:32:32 morfikownia kernel: RIP: 0033:0x79de8c2fef79
> Jun 04 20:32:32 morfikownia kernel: Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d e7 3e 0c 00 f7 d8 64 89 01 48
> Jun 04 20:32:32 morfikownia kernel: RSP: 002b:00007ffeaf5bf6a8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
> Jun 04 20:32:32 morfikownia kernel: RAX: ffffffffffffffda RBX: 00005f050dd29ef0 RCX: 000079de8c2fef79
> Jun 04 20:32:32 morfikownia kernel: RDX: 0000000000000000 RSI: 00005f050cd10358 RDI: 0000000000000003
> Jun 04 20:32:32 morfikownia kernel: RBP: 0000000000040000 R08: 0000000000000000 R09: 00005f050dd2b3f0
> Jun 04 20:32:32 morfikownia kernel: R10: 0000000000000003 R11: 0000000000000246 R12: 00005f050cd10358
> Jun 04 20:32:32 morfikownia kernel: R13: 0000000000000000 R14: 00005f050dd29e90 R15: 00005f050dd29ef0
> Jun 04 20:32:32 morfikownia kernel: BUG: using smp_processor_id() in preemptible [00000000] code: modprobe/5461
> Jun 04 20:32:32 morfikownia kernel: caller is p_parse_module_params+0x1b4/0x28c [p_lkrg]
> Jun 04 20:32:32 morfikownia kernel: CPU: 0 PID: 5461 Comm: modprobe Tainted: G           O    T 5.7.0-amd64 #5
> Jun 04 20:32:32 morfikownia kernel: Hardware name: LENOVO 2349BM5/2349BM5, BIOS G1ETC2WW (2.82 ) 08/07/2019
> Jun 04 20:32:32 morfikownia kernel: Call Trace:
> Jun 04 20:32:32 morfikownia kernel:  dump_stack+0x50/0x68
> Jun 04 20:32:32 morfikownia kernel:  debug_smp_processor_id.cold+0x4e/0x53
> Jun 04 20:32:32 morfikownia kernel:  p_parse_module_params+0x1b4/0x28c [p_lkrg]
> Jun 04 20:32:32 morfikownia kernel:  p_lkrg_register+0x50/0x1000 [p_lkrg]
> Jun 04 20:32:32 morfikownia kernel:  ? 0xffffffffc0499000
> Jun 04 20:32:32 morfikownia kernel:  do_one_initcall+0x5b/0x240
> Jun 04 20:32:32 morfikownia kernel:  do_init_module+0x5f/0x230
> Jun 04 20:32:32 morfikownia kernel:  load_module+0x2709/0x29e0
> Jun 04 20:32:32 morfikownia kernel:  ? __do_sys_finit_module+0xc2/0x120
> Jun 04 20:32:32 morfikownia kernel:  __do_sys_finit_module+0xc2/0x120
> Jun 04 20:32:32 morfikownia kernel:  do_syscall_64+0xa4/0x5f1
> Jun 04 20:32:32 morfikownia kernel:  ? do_syscall_64+0x30/0x5f1
> Jun 04 20:32:32 morfikownia kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xa9
> Jun 04 20:32:32 morfikownia kernel: RIP: 0033:0x79de8c2fef79
> Jun 04 20:32:32 morfikownia kernel: Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d e7 3e 0c 00 f7 d8 64 89 01 48
> Jun 04 20:32:32 morfikownia kernel: RSP: 002b:00007ffeaf5bf6a8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
> Jun 04 20:32:32 morfikownia kernel: RAX: ffffffffffffffda RBX: 00005f050dd29ef0 RCX: 000079de8c2fef79
> Jun 04 20:32:32 morfikownia kernel: RDX: 0000000000000000 RSI: 00005f050cd10358 RDI: 0000000000000003
> Jun 04 20:32:32 morfikownia kernel: RBP: 0000000000040000 R08: 0000000000000000 R09: 00005f050dd2b3f0
> Jun 04 20:32:32 morfikownia kernel: R10: 0000000000000003 R11: 0000000000000246 R12: 00005f050cd10358
> Jun 04 20:32:32 morfikownia kernel: R13: 0000000000000000 R14: 00005f050dd29e90 R15: 00005f050dd29ef0
> Jun 04 20:32:32 morfikownia kernel: [p_lkrg] System does NOT support SMAP. LKRG can't enforce SMAP validation :(
> Jun 04 20:32:32 morfikownia kernel: Freezing user space processes ... (elapsed 0.032 seconds) done.
> Jun 04 20:32:32 morfikownia kernel: OOM killer disabled.
> Jun 04 20:32:32 morfikownia kernel: [p_lkrg] 8/23 UMH paths were whitelisted...
> Jun 04 20:32:32 morfikownia kernel: [p_lkrg] LKRG initialized successfully!
> Jun 04 20:32:32 morfikownia kernel: OOM killer enabled.
> Jun 04 20:32:32 morfikownia kernel: Restarting tasks ... done.
> 

It works fine, per log:

  Jun 04 20:32:32 morfikownia kernel: [p_lkrg] LKRG initialized successfully!

This warning log is not important. It's generated during the process of 
verification if your CPU has SMAP/SMEP bit. In theory running task can be 
reschedule to be run on another CPU and that's why warning is printed. In 
practice if you have (or not) SMEP/SMAP it doesn't matter on each CPU such 
verification happens.
However, it doesn't look clean so I can address that as well.

Thanks,
Adam



-- 
pi3 (pi3ki31ny) - pi3 (at) itsec pl
http://pi3.com.pl

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.