lkrg-users - Re: [PATCH] Makefile: make it less shitty

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180906000537.GA4042@pi3.com.pl>
Date: Thu, 6 Sep 2018 02:05:37 +0200
From: Adam Zabrocki <pi3@....com.pl>
To: lkrg-users@...ts.openwall.com
Subject: Re: [PATCH] Makefile: make it less shitty

Hi,

Thanks for looking at it, but currently I can't merge this patch mainly because 
of that:

	+sources += $(shell find $(src) -type f -name '*.c')
	+objects += $(sources:$(src)/%.c=%.o)

Currently, there is a few .c files which are directly included in other .c 
files. Until I don't change that behaviour it is not the correct way to compile 
object files via enumerating all .c files in src subdirectory.

Thanks,
Adam

On Thu, Sep 06, 2018 at 01:15:04AM +0400, Ilya Matveychikov wrote:
> Tried to cleanup some stuff in Makefile but finally had no luck
> with compilation because of very “specific” way to manage source
> code files...
> 
> Anyways, here is the patch.
> 
> =/
> 

-- 
pi3 (pi3ki31ny) - pi3 (at) itsec pl
http://pi3.com.pl

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.