libc-coord - Re: [PATCH v9 1/1] Extend struct r_debug to support multiple namespaces [BZ #15971]

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sfy8bkty.fsf@oldenburg.str.redhat.com>
Date: Mon, 13 Sep 2021 16:40:09 +0200
From: Florian Weimer <fweimer@...hat.com>
To: "H.J. Lu" <hjl.tools@...il.com>
Cc: libc-alpha@...rceware.org,  gdb@...rceware.org,
  libc-coord@...ts.openwall.com,  Daniel Walker <danielwa@...co.com>
Subject: Re: [PATCH v9 1/1] Extend struct r_debug to support multiple
 namespaces [BZ #15971]

* H. J. Lu:

> +	  /* Add the new namespace to the linked list.  After a namespace
> +	     is initialized, r_brk becomes non-zero.  A namespace becomes
> +	     empty (r_map == NULL) when it is unused.  But it is never
> +	     removed from the linked list.  */
> +	  r->r_next = _r_debug_extended.r_next;
> +	  atomic_store_release (&_r_debug_extended.r_next, r);

I think the addition should be at the end of the list, and the list
update (with release MO) should come last.  That should help with
reading the list concurrently.

Rest looks okay to me.

Thanks,
Florian

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.