kernel-hardening - Re: [PATCH v3 2/3] selftests/x86/Makefile: Support per-target $(LIBS) configuration

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wnj2tpja.fsf@oldenburg.str.redhat.com>
Date: Fri, 14 Jan 2022 14:28:25 +0100
From: Florian Weimer <fweimer@...hat.com>
To: "Andy Lutomirski" <luto@...nel.org>
Cc: linux-arch@...r.kernel.org,  "Linux API" <linux-api@...r.kernel.org>,
  linux-x86_64@...r.kernel.org,  kernel-hardening@...ts.openwall.com,
  linux-mm@...ck.org,  "the arch/x86 maintainers" <x86@...nel.org>,
  musl@...ts.openwall.com,  "Dave Hansen via Libc-alpha"
 <libc-alpha@...rceware.org>,  "Linux Kernel Mailing List"
 <linux-kernel@...r.kernel.org>,  "Dave Hansen" <dave.hansen@...el.com>,
  "Kees Cook" <keescook@...omium.org>,  "Andrei Vagin" <avagin@...il.com>
Subject: Re: [PATCH v3 2/3] selftests/x86/Makefile: Support per-target
 $(LIBS) configuration

* Andy Lutomirski:

> On Thu, Jan 13, 2022, at 2:00 PM, Florian Weimer wrote:
>> * Andy Lutomirski:
>>
>>> On 1/5/22 08:03, Florian Weimer wrote:
>>>> And avoid compiling PCHs by accident.
>>>> 
>>>
>>> The patch seems fine, but I can't make heads or tails of the
>>> $SUBJECT. Can you help me?
>>
>> What about this?
>>
>> selftests/x86/Makefile: Set linked libraries using $(LIBS)
>>
>> I guess that it's possible to use make features to set this per target
>> isn't important.
>
> I think that's actually important -- it's nice to explain to make
> dummies (e.g. me) what the purpose is is.  I assume it's so that a
> given test can override the libraries.  Also, you've conflated two
> different changes into one patch: removal of .h and addition of LIBS.

Do you want me to split this further into two commits?

  selftests/x86/Makefile: Per-target configuration of linked libraries

  Targets can set $(LIBS) to specify a different set of libraries than the
  defaults (or no libraries at all).

And:

  selftests/x86/Makefile: Do not pass header files as compiler inputs

  Filtering out .h files avoids accidentally creating a precompiled
  header.

I didn't want to game commit metrics.

Thanks,
Florian

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.