Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20211002081359.5de4e2b1@oasis.local.home>
Date: Sat, 2 Oct 2021 08:13:59 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Alexander Popov <alex.popov@...ux.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>, Petr Mladek
 <pmladek@...e.com>, "Paul E. McKenney" <paulmck@...nel.org>, Jonathan
 Corbet <corbet@....net>, Andrew Morton <akpm@...ux-foundation.org>, Thomas
 Gleixner <tglx@...utronix.de>, Peter Zijlstra <peterz@...radead.org>, Joerg
 Roedel <jroedel@...e.de>, Maciej Rozycki <macro@...am.me.uk>, Muchun Song
 <songmuchun@...edance.com>, Viresh Kumar <viresh.kumar@...aro.org>, Robin
 Murphy <robin.murphy@....com>, Randy Dunlap <rdunlap@...radead.org>, Lu
 Baolu <baolu.lu@...ux.intel.com>, Kees Cook <keescook@...omium.org>, Luis
 Chamberlain <mcgrof@...nel.org>, Wei Liu <wl@....org>, John Ogness
 <john.ogness@...utronix.de>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Alexey Kardashevskiy <aik@...abs.ru>,
 Christophe Leroy <christophe.leroy@...roup.eu>, Jann Horn
 <jannh@...gle.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Mark
 Rutland <mark.rutland@....com>, Andy Lutomirski <luto@...nel.org>, Dave
 Hansen <dave.hansen@...ux.intel.com>, Will Deacon <will.deacon@....com>,
 David S Miller <davem@...emloft.net>, Borislav Petkov <bp@...en8.de>,
 Kernel Hardening <kernel-hardening@...ts.openwall.com>,
 linux-hardening@...r.kernel.org, "open list:DOCUMENTATION"
 <linux-doc@...r.kernel.org>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, notify@...nel.org
Subject: Re: [PATCH] Introduce the pkill_on_warn boot parameter

On Sat, 2 Oct 2021 14:41:34 +0300
Alexander Popov <alex.popov@...ux.com> wrote:

> Currently, the Linux kernel provides two types of reaction to kernel warnings:
>  1. Do nothing (by default),
>  2. Call panic() if panic_on_warn is set. That's a very strong reaction,
>     so panic_on_warn is usually disabled on production systems.
> 
> >From a safety point of view, the Linux kernel misses a middle way of handling  
> kernel warnings:
>  - The kernel should stop the activity that provokes a warning,
>  - But the kernel should avoid complete denial of service.
> 
> >From a security point of view, kernel warning messages provide a lot of useful  
> information for attackers. Many GNU/Linux distributions allow unprivileged users
> to read the kernel log (for various reasons), so attackers use kernel warning
> infoleak in vulnerability exploits. See the examples:
> https://a13xp0p0v.github.io/2021/02/09/CVE-2021-26708.html
> https://a13xp0p0v.github.io/2020/02/15/CVE-2019-18683.html
> https://googleprojectzero.blogspot.com/2018/09/a-cache-invalidation-bug-in-linux.html
> 
> Let's introduce the pkill_on_warn parameter.
> If this parameter is set, the kernel kills all threads in a process that
> provoked a kernel warning. This behavior is reasonable from a safety point of
> view described above. It is also useful for kernel security hardening because
> the system kills an exploit process that hits a kernel warning.

How does this help? It only kills the process that caused the warning,
it doesn't kill the process that spawned it. This is trivial to get
around. Just fork a process, trigger the warning (it gets killed) and
then read the kernel log.

If this is your rationale, then I'm not convinced this helps at all.

-- Steve

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.