Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 30 Sep 2021 11:20:34 -0700
From: Kees Cook <>
To: Alexander Popov <>
Cc: Dave Hansen <>,
	Peter Zijlstra <>,
	Jonathan Corbet <>,
	Paul McKenney <>,
	Andrew Morton <>,
	Thomas Gleixner <>,
	Joerg Roedel <>, Maciej Rozycki <>,
	Muchun Song <>,
	Viresh Kumar <>,
	Robin Murphy <>,
	Randy Dunlap <>,
	Lu Baolu <>, Petr Mladek <>,
	Luis Chamberlain <>, Wei Liu <>,
	John Ogness <>,
	Andy Shevchenko <>,
	Alexey Kardashevskiy <>,
	Christophe Leroy <>,
	Jann Horn <>,
	Greg Kroah-Hartman <>,
	Mark Rutland <>,
	Andy Lutomirski <>,
	Dave Hansen <>,
	Steven Rostedt <>,
	Will Deacon <>,
	David S Miller <>,
	Borislav Petkov <>,,,,,
Subject: Re: [PATCH] Introduce the pkill_on_warn boot parameter

On Thu, Sep 30, 2021 at 04:55:37PM +0300, Alexander Popov wrote:
> The kernel can hit warning and omit calling __warn() that prints the message.
> But pkill_on_warn action should be taken each time.
> As I can understand now, include/asm-generic/bug.h defines three warning
> implementations:
>  1. CONFIG_BUG=y and the arch provides __WARN_FLAGS. In that case pkill_on_warn
> should be checked in report_bug() that you mention.
>  2. CONFIG_BUG=y and the arch doesn't have __WARN_FLAGS. In that case
> pkill_on_warn should be checked in warn_slowpath_fmt().
>  3. CONFIG_BUG is not set. In that case pkill_on_warn should not be considered.
> Please, correct me if needed.

That looks correct to me, yes.

Kees Cook

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.