Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210625092733.63bde998@oasis.local.home>
Date: Fri, 25 Jun 2021 09:27:33 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Yun Zhou <yun.zhou@...driver.com>
Cc: linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com,
 ying.xue@...driver.com, "Li, Zhiquan" <Zhiquan.Li@...driver.com>
Subject: Re: [PATCH] seq_buf: let seq_buf_putmem_hex support len larger than
 8

On Fri, 25 Jun 2021 15:28:25 +0800
Yun Zhou <yun.zhou@...driver.com> wrote:

> Hi Mr Steven,
> 
> I found that you had ever wanted to enhance trace_seq_putmem_hex() to
> 
> allow any size input(6d2289f3faa71dcc). Great minds think alike. Your
> 
> enhancement will let the function more robust, I think it is very advisable.
> 
> Now we only need modify two lines to solve a little flaw, and to let it
> 
> more more robust.

You are still solving two bugs with one patch, which is considered a no-no.

One bug fix needs to go back to the beginning. If you want to add the
other update, then it could be labeled a fix to that commit. Either
way, it requires two patches.

-- Steve

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.