Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d4684742-452b-6e88-dd51-f1e9c29cb34d@namei.org>
Date: Fri, 23 Apr 2021 05:08:46 +1000 (AEST)
From: James Morris <jmorris@...ei.org>
To: Mickaël Salaün <mic@...ikod.net>
cc: Jann Horn <jannh@...gle.com>, Kees Cook <keescook@...omium.org>, 
    "Serge E . Hallyn" <serge@...lyn.com>, Al Viro <viro@...iv.linux.org.uk>, 
    Andy Lutomirski <luto@...capital.net>, 
    Anton Ivanov <anton.ivanov@...bridgegreys.com>, 
    Arnd Bergmann <arnd@...db.de>, Casey Schaufler <casey@...aufler-ca.com>, 
    David Howells <dhowells@...hat.com>, Jeff Dike <jdike@...toit.com>, 
    Jonathan Corbet <corbet@....net>, Michael Kerrisk <mtk.manpages@...il.com>, 
    Richard Weinberger <richard@....at>, Shuah Khan <shuah@...nel.org>, 
    Vincent Dagonneau <vincent.dagonneau@....gouv.fr>, 
    kernel-hardening@...ts.openwall.com, linux-api@...r.kernel.org, 
    linux-arch@...r.kernel.org, linux-doc@...r.kernel.org, 
    linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
    linux-kselftest@...r.kernel.org, linux-security-module@...r.kernel.org, 
    x86@...nel.org, 
    Mickaël Salaün <mic@...ux.microsoft.com>
Subject: Re: [PATCH v34 08/13] landlock: Add syscall implementations

On Thu, 22 Apr 2021, Mickaël Salaün wrote:

> +
> +	/* No flag for now. */
> +	if (flags)
> +		return -EINVAL;

Good, returning an error here instead of ignoring it is the right 
approach, so apps don't start using this and then break later.


-- 
James Morris
<jmorris@...ei.org>

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.