[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <045eb376-f490-9608-6e54-68d39e83c3f9@gmail.com>
Date: Sun, 28 Feb 2021 12:03:54 +0300
From: Sergei Shtylyov <sergei.shtylyov@...il.com>
To: Romain Perier <romain.perier@...il.com>, Kees Cook
<keescook@...omium.org>, kernel-hardening@...ts.openwall.com,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Valentina Manea <valentina.manea.m@...il.com>, Shuah Khan
<shuah@...nel.org>, Shuah Khan <skhan@...uxfoundation.org>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/20] usbip: usbip_host: Manual replacement of the
deprecated strlcpy() with return values
Hello!
On 22.02.2021 18:12, Romain Perier wrote:
> The strlcpy() reads the entire source buffer first, it is dangerous if
> the source buffer lenght is unbounded or possibility non NULL-terminated.
Length. Possibly?
> It can lead to linear read overflows, crashes, etc...
>
> As recommended in the deprecated interfaces [1], it should be replaced
> by strscpy.
>
> This commit replaces all calls to strlcpy that handle the return values
> by the corresponding strscpy calls with new handling of the return
> values (as it is quite different between the two functions).
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
>
> Signed-off-by: Romain Perier <romain.perier@...il.com>
[...]
MBR, Sergei
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
