Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 20 Nov 2020 12:52:38 +1100 (AEDT)
From: James Morris <>
To: Mickaël Salaün <>,
        Jann Horn <>
cc: "Serge E . Hallyn" <>, Al Viro <>,
        Andy Lutomirski <>,
        Anton Ivanov <>,
        Arnd Bergmann <>,
        Casey Schaufler <>, Jann Horn <>,
        Jeff Dike <>, Jonathan Corbet <>,
        Kees Cook <>,
        Michael Kerrisk <>,
        Richard Weinberger <>, Shuah Khan <>,
        Vincent Dagonneau <>,,,,,,,,,,
        Mickaël Salaün <>
Subject: Re: [PATCH v24 02/12] landlock: Add ruleset and domain management

On Thu, 12 Nov 2020, Mickaël Salaün wrote:

> Cc: James Morris <>
> Cc: Jann Horn <>
> Cc: Kees Cook <>
> Cc: Serge E. Hallyn <>
> Signed-off-by: Mickaël Salaün <>
> ---
> Changes since v23:
> * Always intersect access rights.  Following the filesystem change
>   logic, make ruleset updates more consistent by always intersecting
>   access rights (boolean AND) instead of combining them (boolean OR) for
>   the same layer.  This defensive approach could also help avoid user
>   space to inadvertently allow multiple access rights for the same
>   object (e.g.  write and execute access on a path hierarchy) instead of
>   dealing with such inconsistency.  This can happen when there is no
>   deduplication of objects (e.g. paths and underlying inodes) whereas
>   they get different access rights with landlock_add_rule(2).
> * Add extra checks to make sure that:
>   - there is always an (allocated) object in each used rules;
>   - when updating a ruleset with a new rule (i.e. not merging two
>     rulesets), the ruleset doesn't contain multiple layers.
> * Hide merge parameter from the public landlock_insert_rule() API.  This
>   helps avoid misuse of this function.
> * Replace a remaining hardcoded 1 with SINGLE_DEPTH_NESTING.

Jann: any chance you could review this patch again given the changes 


James Morris

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.